[Mne_analysis] Possible regression for reading EDF files in version 0.17

[Eisenman, Lawrence]

        External Email - Use Caution        

I have data files in EDF format that contain both SEEG and surface electrodes. Our naming strategy for SEEG electrodes results in some duplicate names of surface EEG electrodes. Prior versions of MNE raised a runtime warning and appended sequential digits to the electrode names. The current version now raises an error such as "ValueError: Channel EEG F1-Ref-0 has no associated original unit."

If dropping support for duplicate electrode names was the desired intent, it would probably be better to change the runtime warning into an error so the problem is clear.

If this was not the intent, I have a test file demonstrating the problem and an EDF specific solution that I can make into a pull request. The new behavior appears to have occurred as  result of changes meant to make the original units available in the final raw data structure. Please let me know if I should proceed with making a pull request. Thanks.

Larry

________________________________
The materials in this message are private and may contain Protected Healthcare Information or other information of a sensitive nature. If you are not the intended recipient, be advised that any unauthorized use, disclosure, copying or the taking of any action in reliance on the contents of this information is strictly prohibited. If you have received this email in error, please immediately notify the sender via telephone or return mail.